Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation for array input fields #2721

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Fix validation for array input fields #2721

merged 1 commit into from
Mar 22, 2020

Conversation

musmanikram
Copy link
Contributor

@musmanikram musmanikram commented Mar 18, 2020 •
edited
Loading

Fix #2714

Description
In function _array_search_dot empty check for $currentIndex was failing for index 0 in array.
empty() will return true for value 0.

Details: https://www.php.net/manual/en/function.empty.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@musmanikram
Copy link
Contributor Author

@MGatner can you please merge this also? It's issue has been closed by the reporter.
Because i gave him a solution

@lonnieezell lonnieezell merged commit 33b61a7 into codeigniter4:develop Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array validation has a problem
2 participants
@musmanikram @lonnieezell